OpenVoiceOS / OpenVoiceOS/ovos-date-parser

Inconsistent parameter naming across language handlers

Open
#66 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 11, 2024.

Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

There is an inconsistency in parameter naming across language handlers. The parameter anchorDate has been renamed to anchor_date only in the Russian and Ukrainian handlers, while other language handlers and the main function signature still use anchorDate. This inconsistency should be addressed.

See PR #64: https://github.com/OpenVoiceOS/ovos-date-parser/pull/64
See comment: https://github.com/OpenVoiceOS/ovos-date-parser/pull/64#discussion_r1836856093

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.