OpenVoiceOS / OpenVoiceOS/ovos-date-parser

Enable or remove commented test cases for non-speech duration formatting

Open
#55 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 7, 2024.

Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

In the file test/format_tests/test_format_uk.py, there are commented-out test cases for non-speech duration formatting.

Since the implementation raises NotImplementedError when speech=False, we should either implement this functionality, remove the commented tests, or convert them to skipped tests to track this planned feature.

Refer to PR #51 and this comment by @JarbasAl.

Requested by @JarbasAl.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.