OpenVoiceOS / OpenVoiceOS/ovos-date-parser

Expand date-time test coverage in 'fa-ir/date_time_test.json'

Open
#5 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 7, 2024.

fa
Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

As per the discussion in PR #1, we need to expand the date-time test coverage to include additional test cases.

Comment reference: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1#discussion_r1831942272

Details:
The current test cases only cover a single afternoon time. We should add tests for:

  1. Midnight (00:00) and noon (12:00)
  2. Morning times (AM)
  3. Edge cases like 23:59:59
  4. Single-digit hours and minutes (e.g., 01:05, 5:08)

Requester: @JarbasAl

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.