OpenVoiceOS / OpenVoiceOS/ovos-date-parser

cs/Expand time format test coverage

Open
#47 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 7, 2024.

cs
Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

This issue is to track the expansion of time format test coverage as discussed in PR #1 (link) under this comment. @JarbasAl requested to open this issue for tracking.

🛠️ Refactor suggestion

Expand time format test coverage significantly.

The current coverage is minimal. Consider adding test cases for:

  1. Special times:

    • Midnight (00:00)
    • Noon (12:00)
    • AM/PM transitions
    • Single-digit hours
    • Various minute combinations

  2. Format variations:

    • Leading zeros
    • With/without seconds
    • Different time zones

This will ensure robust handling of all time formatting scenarios.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.