OpenVoiceOS / OpenVoiceOS/ovos-date-parser
Expand time format test coverage
Open
@JarbasAl is already working on this.
Since Nov 7, 2024.
en
- Dominant language
- Python
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 9m
- Merged PRs (30d)
- 17
Description
Description
Track the expansion of time format test coverage.
ovos_date_parser/res/en-us/date_time_test.json
🛠️ Refactor suggestion
Improve test data structure and coverage in test_nice_year section.
Several improvements are needed for better test data structure and coverage:
- Use proper JSON array format for datetime_param instead of comma-separated strings
- Use JSON boolean values instead of strings for the "bc" field
- Add missing test cases for edge scenarios
Apply these changes to improve the test data structure:
"test_nice_year": {
- "1": {"datetime_param": "1, 1, 31, 13, 22, 3", "bc": "True", "assertEqual": "one b.c." },
+ "1": {"datetime_param": [1, 1, 31, 13, 22, 3], "bc": true, "assertEqual": "one B.C." },
Consider adding these test cases:
{
"25": {"datetime_param": [0, 1, 31, 13, 22, 3], "bc": false, "assertEqual": "zero"},
"26": {"datetime_param": [9999, 1, 31, 13, 22, 3], "bc": false, "assertEqual": "nine thousand nine hundred ninety nine"},
"27": {"datetime_param": [10000, 1, 31, 13, 22, 3], "bc": false, "assertEqual": "ten thousand"}
}
Requester: @JarbasAl
References:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.