OpenVoiceOS / OpenVoiceOS/ovos-date-parser
Improve test coverage for Dutch locale in ovos-date-parser
Open
@JarbasAl is already working on this.
Since Nov 7, 2024.
nl
- Dominant language
- Python
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 9m
- Merged PRs (30d)
- 17
Description
Description
There is a need to enhance the test cases for the Dutch locale in the ovos-date-parser project. The current tests:
- Default to 12-hour format (
use_24hour=False), whereas Dutch locales primarily use the 24-hour format. - Lack essential test scenarios, such as:
- Midnight ("middernacht")
- Quarter hours ("kwart over/voor")
- Half hours ("half")
- Different parts of the day ("'s nachts", "'s ochtends", "'s middags", "'s avonds")
References
- Pull Request: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1
- Comment: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1#discussion_r1831942324
- Reported by: @JarbasAl
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.