OpenVoiceOS / OpenVoiceOS/ovos-date-parser

Expand time format test coverage in Hungarian date_time_test.json

Open
#37 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 7, 2024.

hu
Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

As per the discussion in PR #1 and this comment, we need to expand the time format test coverage in ovos_date_parser/res/hu-hu/date_time_test.json. The current test cases only cover a single time (13:22). The user @JarbasAl requested to open this issue to track this enhancement.

🛠️ Refactor suggestion

Expand time format test coverage

The current test cases only cover a single time (13:22). Consider adding test cases for:

  • Midnight (00:00) and noon (12:00)
  • Various morning hours (AM)
  • Various evening hours (PM)
  • Minute transitions (e.g., 8:59, 9:00)

Example additional test cases:

{
  "3": {"datetime_param": "2017, 1, 31, 0, 0, 0", "now": "None", "use_24hour": "False", "use_ampm": "True", "assertEqual": "kétezer-tizenhét január harmincegyedike, kedd, éjfél"},
  "4": {"datetime_param": "2017, 1, 31, 12, 0, 0", "now": "None", "use_24hour": "False", "use_ampm": "True", "assertEqual": "kétezer-tizenhét január harmincegyedike, kedd, dél"},
  "5": {"datetime_param": "2017, 1, 31, 8, 59, 0", "now": "None", "use_24hour": "True", "use_ampm": "False", "assertEqual": "kétezer-tizenhét január harmincegyedike, kedd, nyolc óra ötvenkilenc"}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.