OpenVoiceOS / OpenVoiceOS/ovos-date-parser
Expand date-time format test coverage
Open
@JarbasAl is already working on this.
Since Nov 7, 2024.
sl
- Dominant language
- Python
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 9m
- Merged PRs (30d)
- 17
Description
As discussed in PR #1, we need to expand the date-time format test coverage.
ovos_date_parser/res/sl-si/date_time_test.json
🛠️ Refactor suggestion
Expand date-time format test coverage.
The current test cases only cover basic scenarios. Consider adding tests for:
Special times (midnight 00:00, noon 12:00)
Single-digit hours (both 24h and 12h formats)
Various minute values (00, 01, 15, 30, 45, 59)
Second precision handling
AM/PM boundary cases (11:59 AM → 12:00 PM)
This would ensure more robust handling of edge cases in time formatting.
Requested by @JarbasAl.
References:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.