OpenVoiceOS / OpenVoiceOS/ovos-date-parser

de/Adjust weekday indexing to match standard convention in date_time.json

Open
#30 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 7, 2024.

de
Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

There is a potential issue in ovos_date_parser/res/de-de/date_time.json where the weekday indexing starts from Monday (0) instead of the standard convention where Sunday is 0. This might cause compatibility issues with datetime libraries.

Adjust weekday indexing to match standard convention.

The current indexing (Monday = 0) differs from the standard convention where Sunday = 0. This might cause compatibility issues with datetime libraries.

   "weekday": {
-    "0": "Montag",
-    "1": "Dienstag",
-    "2": "Mittwoch",
-    "3": "Donnerstag",
-    "4": "Freitag",
-    "5": "Samstag",
-    "6": "Sonntag"
+    "0": "Sonntag",
+    "1": "Montag",
+    "2": "Dienstag",
+    "3": "Mittwoch",
+    "4": "Donnerstag",
+    "5": "Freitag",
+    "6": "Samstag"
   },

Referenced in PR: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1
Comment URL: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1#discussion_r1831942344

Reported by @JarbasAl.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.