OpenVoiceOS / OpenVoiceOS/ovos-date-parser
Fix overlapping year_format patterns in Italian date_time.json
Open
@JarbasAl is already working on this.
Since Nov 7, 2024.
it
- Dominant language
- Python
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 9m
- Merged PRs (30d)
- 17
Description
There are duplicate and overlapping patterns in the year_format rules that could lead to inconsistent formatting.
- Rules 8 and 11 are identical, both matching
^20\d{2}$ - Rules 9 and 12 have overlapping patterns that could match the same years
This issue was initially flagged in PR #1 by @JarbasAl.
PR URL: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1
Comment URL: https://github.com/OpenVoiceOS/ovos-date-parser/pull/1#discussion_r1831942351
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.