OpenVoiceOS / OpenVoiceOS/ovos-date-parser
Incomplete number translations in Persian date_time.json
@JarbasAl is already working on this.
Since Nov 7, 2024.
- Dominant language
- Python
- Stars
- 0
- Forks
- 8
- Avg merge
- 7h 9m
- Merged PRs (30d)
- 17
Description
The number translations section in res/fa-ir/date_time.json is missing values between decades (21-29, 31-39, etc.). These are needed for complete number formatting support.
This issue was identified in PR #1 in this comment.
⚠️ Potential issue
Complete number translations for all values.
The number translations section is missing values between decades (21-29, 31-39, etc.). These are needed for complete number formatting support.
Please add the missing number translations. The current implementation will fail for numbers like 45, 67, etc.
Consider using a number composition system:
"number_composition": {
"connector": "و",
"format": "{tens} {connector} {ones}"
}
cc @JarbasAl
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.