OpenVoiceOS / OpenVoiceOS/ovos-date-parser

fr/Expand time format test coverage

Open
#25 0 comments 0 reactions 1 assignee View on GitHub

@JarbasAl is already working on this.

Since Nov 7, 2024.

fr
Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

As discussed in PR #1 (comment), we need to expand the test coverage for time formatting.

ovos_date_parser/res/fr-fr/date_time_test.json

Critical: Expand time format test coverage

The current test coverage for time formatting is insufficient. Please add test cases for:

Hour-specific formations:
    "midi" and "minuit" instead of "12 heures"
    Hours with "heure" vs "heures"
    Quarter and half hours ("et quart", "et demie")

Minute variations:
    Minutes requiring "et" vs direct number
    Zero minutes (suppression of minutes)

Time ranges and approximate times:
    "vers", "environ"
    "moins le quart"

Requested by @JarbasAl.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.