OpenVoiceOS / OpenVoiceOS/ovos-date-parser

uk/Pattern ^[34][34]\d{2}$ is too restrictive for Ukrainian year formatting

Open
#19 0 comments 0 reactions 2 assignees View on GitHub

@NeonDaniel is already working on this.

Since Nov 7, 2024.

uk
Dominant language
Python
Stars
0
Forks
8
Avg merge
7h 9m
Merged PRs (30d)
17

Description

As per this comment in PR #1, @JarbasAl requested to open an issue to track the discussion.

ovos_date_parser/res/uk-ua/date_time.json

Pattern ^[34][34]\d{2}$ is too restrictive for Ukrainian year formatting

The test cases across multiple languages show that years between 3000-4000 follow consistent formatting patterns. The current regex ^[34][34]\d{2}$ only matches years like 3300-3499 and 4300-4499, but excludes valid cases like 3500-3999 that should follow the same format rule.

The pattern should be changed to ^[34]\\d{3}$ to cover all years in the 3000-4999 range
Line 14 can be removed since its pattern is now redundant with line 15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.