Signature of socket_protect in OpenVPNClientThread.java isn't correct
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.2k
- Forks
- 467
- PR merge metrics
- No merged PRs in 30d
Description
Running openvpn3/javacli/build-linux gives
OpenVPNClientThread.java:203: error: method does not override or implement a method from a supertype
@Override
^
1 error
The signature of socket_protect should be
@Override
public boolean socket_protect(int socket, String remote, boolean ipv6) {
EventReceiver p = parent;
if (p != null)
return p.socket_protect(socket);
else
return false;
}
With this change, and upgrading java to version 11, the java compile is correct
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in openvpn3/javacli/OpenVPNClientThread.java at the socket_protect method around line 203, then run openvpn3/javacli/build-linux with Java 11. Done means the Java client compiles without the method-override error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- build-system, cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100