OpenVPN / OpenVPN/openvpn3-indicator

openvpn3-indicator should verify session status when user credentials has been collected

Open
#5 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
118
Forks
24
PR merge metrics
No merged PRs in 30d

Description

If starting a VPN session from the command line (like openvpn3 session-start) which requires user credentials, the indicator will pop up the query box. This is actually quite cool! But if the credentials are provided via the command line, clicking "Cancel" will kill the VPN session.

The openvpn3-indicator should check that the session minor status is still CFG_REQUIRE_USER before doing the disconnect. This pop-up should ideally also detect if the session state changes while being open and close the pop-up automatically if the session changes to any of the other CONN_* minor statuses.

The openvpn3 command line will also need to be adopted a bit to also avoid similar misbehaviour; I'll tackle that as part of the GDBus++ refactoring already in progress.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the openvpn3-indicator credential query and Cancel flow, using openvpn3 session-start as the reproduction entry point. Verify the session minor status before disconnecting, and observe state changes while the prompt is open. Done means Cancel no longer disconnects a session whose credentials were supplied on the command line, and the prompt closes when the session reaches another CONN_* status.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
desktop, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.