OpenVPN / OpenVPN/openvpn

plugin_auth_pam: change default sync/async operation

Open
#893 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
14.6k
Forks
3.4k
PR merge metrics
No merged PRs in 30d

Description

As of today, the auth-pam plugin defaults to sync operation, which has known drawbacks ("freeze the whole process"). To enable async/deferred mode, setenv deferred_auth_pam yes must be used.

We should change from opt-in to opt-out, and make the default async. This has been out in the field for a long time and has had time to really shake down any leftover bugs.

Brought up by @R9295 - give credits when changing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the auth-pam plugin and the handling of the deferred_auth_pam setting. Check how the current default and opt-out path are represented in the plugin and its tests or configuration documentation; done means async/deferred operation is the default while an explicit setting can select synchronous operation.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
authentication, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.