Socket group restrictions issue
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.6k
- Forks
- 3.4k
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
The management-group directive checks against getpeereid that the peer is in the correct group (manage.c and socks.c).
However this function returns only the primary guid and not other group the user might belong to, giving an access denied when group is not the primary group of the user.
As well, root access is not checked and root is rejected, which of course is not expected. A uid of 0 or a gid of 0 should grant access.
thanks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the management-group checks in manage.c and socks.c, then inspect how getpeereid supplies peer identity and group information. Done means supplementary group membership is accepted and uid 0 or gid 0 grants access; the issue does not name a test to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100