No error when tram_type property is set without a tram typetable
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 59
- Forks
- 46
- Avg merge
- 11d 15h
- Merged PRs (30d)
- 3
Description
If a tram is created with no tram_type property, OpenTTD will use the default ELRL. But if a tram_type property is set (even to ELRL) without a tramtypetable, OpenTTD does not default to ELRL
NML should throw an error in this scenario.
Possibly also around some similar "You've set tram_type but no ROADVEH_FLAG_TRAM" edge cases (and vice versa), if required, I generally found it a bit confusing to create a tram with no feedback when I was missing properties and multiple are required
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by tracing validation for tram_type, tramtypetable, and ROADVEH_FLAG_TRAM, then reproduce the missing-property cases; done means NML reports an error for the stated scenario and clarifies any related tram consistency checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100