OpenTTD / OpenTTD/OpenMSX

No tests (make check) is possible

Open
#22 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
29
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Hi!
It seems, that 'make check' cannot be executed, as files? seems to be missing.

Basically, make check will always fail:
/usr/bin/grfid -m openmsx.grf > openmsx.md5
Unable to get requested information: Unable to open file

The problem is, the .grf is never created. If I try to run manually make grf, it will also fail, because it complains of missing openmsx.pnml

[CPP] openmsx.nml
cc -D REPO_REVISION=0 -D NEWGRF_VERSION=0  -C -E -nostdinc -x c-header -o openmsx.nml openmsx.pnml
cc1: fatal error: openmsx.pnml: No such file or directory
compilation terminated.

I am not sure, is it missing or does it has to be created somehow? I can't find anything realated about creation in the Makefile.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Makefile and its check and grf targets, then trace why openmsx.pnml is unavailable when the C preprocessor runs. Reproduce make check and make grf; done means the missing input or generation step is resolved and make check completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.