OpenSourceBrain / OpenSourceBrain/osb-model-validation

Do not silently start downloading missing bits assuming installation in hard-coded default locations

Open
#74 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
XSLT
Stars
9
Forks
11
PR merge metrics
No merged PRs in 30d

Description

I have jnml installed in the right location: /usr/bin/. However, because OMV has the default location hard-coded as ~/jnml/jNeuroMLJar/, if it doesn't find it there, it just starts to download the thing. There's really no reason why users should have individual directories in ~/ for each software. This is not a standard location (not FHS or XDG or any other standard that I'm aware of). Most people will have a specific folder where they install software locally. So, this needs to be improved:

We should:

  • first check a list of sane default locations: such as $PATH on Linux systems to see if the necessary command is available
  • if the command is not found, we should inform the user and ask them to explicitly set the necessary environment variable to point to their installation,
  • a specific value of the environment variable could be used to request OMV to download the artefact itself. For example JNML_HOME="omv-download".

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the OMV code that resolves jNeuroMLJar and handles JNML_HOME, then inspect how its current fallback download works. Done means standard locations are checked, missing installations produce clear guidance, and an explicit download value remains supported.

Written by the indexing model from the issue text.

Assessment

Domain
cli, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.