OpenSlides / OpenSlides/openslides-meta

Reduce trigger functions for equal fields

Open
#458 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clean up enhancement
Dominant language
PLpgSQL
Stars
0
Forks
25
Avg merge
1d 2h
Merged PRs (30d)
12

Description

To reduce them we have two approaches. Either combining them with parameter adjustment and logic changes or removing/altering such fields.
The latter can be done for:

  • option/content_object_id : user/option_id (Here we would need to reference meeting_user instead and would get rid of two functions)
  • projection/content_object_id : meeting/projection_ids (Here we would need to add an in-between model like welcome_card.)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the trigger functions associated with option/content_object_id and projection/content_object_id, then trace their references to user/option_id, meeting_user, meeting/projection_ids, and the proposed welcome_card model. The issue needs a design decision between combining functions and altering fields; done requires an agreed approach and confirmation that the redundant trigger functions can be removed or consolidated.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql
Domain
databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.