OpenSlides / OpenSlides/openslides-client
Refactor `base-filter-list.service.ts`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 35
- Forks
- 52
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 52
Description
The base-filter-list.service.ts is grown huge and there are some functions, that only pass some values to another function.
The functions can be separated into an own class. Then, we can for example build an instance of the class and call class methods to achieve the same things.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading base-filter-list.service.ts and identify the functions that only pass values to another function. Trace their callers before deciding which operations belong in a separate class. Done means the extracted class can provide the same behavior while reducing the size of the service.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100