OpenSlides / OpenSlides/openslides-client

Review logging

Open
#909 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs discussion
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

See https://github.com/OpenSlides/OpenSlides/issues/6380

The client should reduce the logging in log level info.

At the moment I get something like

inst-client-1           | 192.168.16.10 - - [03/Mar/2022:22:36:35 +0000] "GET /polyfills.7d4bbb442dc7356c6a6a.js HTTP/1.1" 200 34267 "https://localhost:8000/" "Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Firefox/97.0"

in production mode for every HTTP request every time. We may reduce this and log such request with Status < 500 in debug mode only. Requests with Status >= 500 can be logged with loglevel error. Is this ok for you?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the related issue #6380 and locating the client’s HTTP request logging entry point. Check how production requests are currently logged, then verify that successful requests are quieter while status codes below 500 remain debug-only and status codes at or above 500 are logged at error level.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, observability
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.