OpenSlides / OpenSlides/openslides-client
Meeting/Committee edit: Save button active without a change done
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 35
- Forks
- 52
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 52
Description
Describe the bug
Currently in several setting menus the save button is active, even if no changes are done.
Affected setting menus:
- Meeting edit mask
- Committee edit mask
How to Reproduce
- open one of these setting menus
Expected behavior
The Save button should only be clickable if changes are done.
Context
This is caused by the base-form-field-control.ts which defaults to marking inputs as touched and dirty when initializing the component.
A clean fix should be implemented for this that includes
- Renaming
BaseFormFieldControlComponent<T>toBaseLegacyFormFieldControlComponent<T> - Creating
BaseFormFieldControlComponent<T>fulfilling the interface for signal form controls (https://angular.dev/guide/forms/signals/custom-controls) - Either do the same for
BaseSearchSelectorComponentor migrate all dependents - Make
BaseSearchSelectorComponentmore flexible.Identifiableon theSelectabletype is too restrictive as it prevents us from usingstringkeys. - Update at least
AccountSearchSelectorComponentto use new underlyingBaseFormFieldControlComponent
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading base-form-field-control.ts and the Angular signal form custom-controls guidance linked in the issue. Trace BaseSearchSelectorComponent and AccountSearchSelectorComponent to identify affected dependents. Done means the meeting and committee Save buttons stay inactive until changes are made, while the requested legacy rename, signal-control implementation, selector flexibility, and AccountSearchSelector migration are complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100