OpenSlides / OpenSlides/openslides-client

Fix chips for states and recommendations in motions

Open Beginner friendly
#6,223 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Describe the bug
Similar to the fix for #6112 the buttons for states and recommendations in motions should be fully clickable.
(Especially compared to chips for categories, motion blocks or phases in an election.)

This part is not clickable:

Image

Only the text part of the chip is clickable:

Image

How to Reproduce

  1. Open a motion
  2. Click on the state/recommendation

Expected behavior
The entire button should be clickable.

Additional info
Please also make sure that the chip should not suggest to be clickable if you can not change the state, e.g. as a delegate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open a motion and trace the components that render the state and recommendation chips, comparing their behavior with category, motion-block, and phase chips and the fix in #6112. Done means the whole chip is clickable when the user can change the state, while chips for users such as delegates who cannot change it do not suggest clickability.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.