OpenSlides / OpenSlides/openslides-client

Original/Changed version view of amendments do not prevent duplicate CR creation

Open
#6,218 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Describe the bug
It is possible to open the dialog for creating change recos on lines where a change reco already exists when on changed/original version on amendments.

How to Reproduce

  1. Create amendment
  2. Create change reco
  3. Go to changed/original version
  4. It is still possible to select the lines with an existing change reco

Expected behavior
The selection buttons should not be available.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the amendment changed/original version view and the dialog or selection controls for creating change recos. Reproduce the three-step sequence in the issue, then follow how lines with an existing change reco are represented and selected. Done means those selection buttons are unavailable for existing change recos in both views.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.