OpenSlides / OpenSlides/openslides-client

Change Recommendation: failure in diff visuals

Open
#5,912 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Describe the bug
A strange bug occurs with change recommendations. The change recommendation changes the diff view after the edit menu is opened again. In first state the diff is wrongly displayed. After opening the edit again, the diff will be shown correctly.

The problem seems to occur with a special format like bold.

Example - diff before opening the edit
Image

Diff after opening the change reco edit
Image

How to Reproduce

  1. open a meeting
  2. open motions > create a motion with the motion text below
  3. open the motion > add a change recommendation to line 3 with the text below
  4. edit the change reco > diff will change

Motion text code

<p>Jemand musste Josef K. verleumdet haben, denn ohne dass er etwas Böses getan hätte, wurde er eines Morgens verhaftet. Wie ein Hund! sagte er, es war, als sollte die Scham ihn überleben. Als Gregor Samsa eines Morgens aus unruhigen <strong>Träumen erwachte, fand er sich in seinem Bett zu einem ungeheueren Ungeziefer verwandelt.</strong>

Change reco code

<p class="os-split-after os-split-before">Scham sie überleben und Als Gregor Samsa eines Morgens aus unruhigen <strong>Träumen,</strong></p>

Expected behavior
The correct diff should always appear. Different format options like bold, italic, underlined and crossed out should have no effect on the diff.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue through a meeting's motions: create a motion, add a change recommendation on line 3, and reopen its edit view. Compare the diff before and after reopening, using the provided HTML with bold formatting as the case to verify. Done means the diff remains correct for bold, italic, underlined, and crossed-out formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.