OpenSlides / OpenSlides/openslides-client

Back button in amendmend view becomes viscious circle

Open
#5,453 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Describe the bug
When you enter the amendment view of an amendment to a motion through "show all amendments" and then use the top left corner back button to go back, you end up in a circle, looping between the list of amendments to motion and the amendment you just visited.

How to Reproduce

  1. Create a motion.
  2. Create an amendment.
  3. Open the motion through the motions page.
  4. Click on the link "1 Amendment" in the meta data of the motion view.
  5. Click on your amendment.
  6. Click on the back arrow in the top left corner. (You should now be back in the list of amendments)
  7. Click on the back arrow in the top left corner,
  8. You're back at the amendment view.

Expected behavior
8. You're at the motion view.
Instead of circling back and forth between amendment view and the list of amendments, I expect to get back to the higher level.

Additional context
This error has been there for a long time already, I've just not gotten to reporting it.
It links a bit to the issue #3238 for better navigation in the motions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the navigation flow from the motions page through the amendment list and amendment view, then inspect the back-button routing for those views. Done means the first back action returns to the amendment list and the second returns to the motion view without looping.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.