OpenSlides / OpenSlides/openslides-client

Diff-error with H2 heading

Open
#4,992 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Describe the bug
If an amendment is done to a text with a h2 heading format, the difference view is wrong in the motion. The whole text is marked as change, not onyl the relevant part of it. The amendment instead shows the correct dif-view.

Example - I've changed a word in the heading. (amendment view - correct diff-view)
Image

View of the amendmend in the motion. (wrong diff-view)
Image

How to Reproduce

  1. open a meeting
  2. open motions
  3. create a motion with a h2 heading
  4. create an amendment to the heading and change one word in it

Expected behavior
The diff-view in the motion should show only the correct change and should not mark the whole text as change.

Additional context
This is part of the META Diff Issue #2956

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by creating a motion with an H2 heading, amending one word in that heading, and comparing the amendment diff with the motion diff. Trace the motion and amendment diff-view entry points, using META Diff Issue #2956 for context; done means the motion view marks only the changed text rather than the whole heading or document.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.