OpenSlides / OpenSlides/openslides-client

Fix display of amendment with formatting

Open
#4,755 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

This is the new description from: https://github.com/OpenSlides/openslides-client/issues/4452

Description:
If you have formatting in the motion anf Umlaute then changeing part of the formating and more with the amendment breaks the amendment.

Broken formatting:

  • Bold + Italic
  • Bold + underlined
  • Bold + strikethrough
  • Bold + Italic + underlined
  • Bold + Italic + strikethrough
  • Bold+italic+underlined+strikethrough
  • Italic + underlined
  • italic + strikethrough
  • italic + underlined + strike
  • underlied + strikethrough
  • all combinations with text color -> these can also get heir own Issue if the others above are fixed
  • all combinations with background color -> these can also get heir own Issue if the others above are fixed

the motion text:

<p>Und es war ihnen wie eine <strong>
<em>Bestätigung</em>
</strong> ihrer neuen Träume und guten Absichten, als am Ziele ihrer Fahrt die Tochter als erste sich erhob und ihren jungen <strong>
<em>Körper</em>
</strong> dehnte. motion with two paragraphs. Add in the second paragraph a bold formatting of one word in the first and in the second senence.</p>

Example amendment test for bold and italic (line 5-7 was changed):

<p>Und es war ihnen wie eine <strong>
<em>Bestätigung</em>
</strong> ihrer neuen Träume und guten Absichten, als am Ziele ihrer Fahrt die Tochter als erste sich erhob und ihren jungen alten <strong>
<em>Körpergehülle</em>
</strong> dehnte. motion with two paragraphs. Add in the second paragraph a bold formatting of one word in the first and in the second senence.</p>

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the two HTML snippets in the issue as reproduction inputs and compare amendment output for the listed formatting combinations, including umlauts. Locate the client-side amendment and formatting entry points, then add coverage showing that formatting is preserved after edits and verify the listed cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.