OpenSlides / OpenSlides/openslides-client

Fix custom Fonts

Open
#3,640 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Current behaviour:
If a font is uploaded in the file-list and activated for certain Fonts then this font is not working correctly

Reproduction:
The wrong behaviour is on the projector

  1. create a motion, the text needs certain stylings (regular, italic, bold, bold'n'italic) (screenshot for visuals)
  2. Navigate to the file-list in a meeting
  3. upload a font (for testing choose a font you can visually distinguish from the regular fonts)
  4. If you activate the font for some fonts too much is changed
  5. If you activate the font for some fonts nothing is changed
    ...:
  • 'Font regular': changes regular text and cursive text
  • 'Font italic': changes nothing
  • 'Font bold': changes bold and bold italic text
  • 'Font bold italic': changes nothing
  • 'monospace' is used by the timers: and the timers do not use the selected font (on the autopilot the and by the structure level time the font it used)

Screenshot (mono space is missing from the screenshot):
Screenshot_20240503_140025

Wanted behaviour:

  • regular and kursive should be merged into one option ("Font not bold") the function should do what "Font regular" does at the moment
  • bold and bold'n'kursive should be merged into one option ("Font bold") the function should do what "Font bold" does at the moment
  • Remove monospace

New wanted behaviour:

  • Every text should activate the text it describes
  • "Font monospace" should be changesd to "Font for timers"
  • The monospace font should work for every timer

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the font activation behavior in the projector from the file-list, using regular, italic, bold, bold italic, and monospace timer text. Trace how each uploaded font option is applied, then verify that each option affects the text it describes and that the monospace timer font works for every timer.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.