OpenSlides / OpenSlides/openslides-client

Investigate `get_forwarding_meetings` and `motion.create_forwarded`

Open
#3,067 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug low needs investigation
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

See OpenSlides/openslides-backend#2003 and OpenSlides/openslides-backend#2009

According to tracebacks in the logs it seems these two processes were called with insufficient payloads.

The get_forwarding_meetings presenter was seemingly called with a payload that didn't contain a meeting_id
The motion.create_forwarded action was seemingly called without a meeting_id and, another time, without an origin_id.
The latter action also has other required fields, but they would not have caused the same error in the backend.

Please take a good look at these actions in particular and check if the client can actually be made to send these types of payloads and, if yes, fix that

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading OpenSlides/openslides-backend#2003 and #2009, then search the client for the get_forwarding_meetings presenter and motion.create_forwarded action. Trace where their payloads are assembled and compare them with the required meeting_id and origin_id fields. Done means the client cannot send the insufficient payloads described in the logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.