OpenSlides / OpenSlides/openslides-client
Handling of autoupdate `receivedData` rejection
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 35
- Forks
- 52
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 52
Description
Currently we do not take into account that a autoupdate subscription could fail. This got relevant now with the ability to pause the autoupdate service.
Especially the implementation of ModelRequestService.waitSubscriptionReady could be improved to be more error resistant. Also usages of ModelRequestService.fetch currently all ignore that the promise could be rejected.
This issue needs to be addressed before things like loading bars in list views or similar things can be implemented.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ModelRequestService.waitSubscriptionReady and trace all usages of ModelRequestService.fetch mentioned in the issue. Review how rejected autoupdate subscriptions and fetch promises are currently handled, then verify that failures are surfaced consistently and no relevant caller ignores rejection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100