OpenSlides / OpenSlides/openslides-client

React to a 413 (Content too large) response

Open
#2,732 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

As planned and currently done in https://github.com/OpenSlides/openslides-proxy/pull/4 the proxy will start responding with 413 when request payloads exceed (per default 250M) in size.

The client should handle this appropriately.
Imo a short message a snack box should suffice.

Also we could include the REQUEST_BODY_MAX_SIZE env var to the client. This way the client can also communicate the current limit to the user.
Alternatively we might want to have a statically-served-by-the-proxy route to get the limit. This would have to advantage of having to only restart the proxy when changing the limit.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No client files or tests are named; start by locating the existing handling for HTTP error responses and snack messages. Implement a clear response to status 413, then verify that the client communicates the payload limit if the project settles on using REQUEST_BODY_MAX_SIZE or a proxy-served limit endpoint.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.