OpenSlides / OpenSlides/openslides-client

Amendments: change recommendation diff doesn't work

Open
#2,504 10 comments 0 reactions 2 assignees View on GitHub

@rrenkert is already working on this.

Since Sep 11, 2023.

bug needs discussion
Dominant language
TypeScript
Stars
35
Forks
52
Avg merge
1d 9h
Merged PRs (30d)
52

Description

Description: Recommendations with crossed out lines done in amendments are not displayed. The line will just disappear without a diff-hint. This isn't optimal. It is not easy to recognize, what content is crossed out.

Original amendment:
Screenshot_20230707_105842

Crossed out sentence:
Screenshot_20230707_105933

Reproduction:

  1. open a meeting
  2. open motions
  3. create a motion
  4. add an amendment to the motion
  5. add a change recommendation to the amendment content by deleting a word or more content.

What should happen:
The diff should display in the amendment the crossed out line done by the change recommendation. With this change users could easily spot diffs. Also the diff would be visible in the projection.

Note: The issue is linked to #2503

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.