OpenSlides / OpenSlides/openslides-backend

[ReAct] Lock more earlier

Open
#3,766 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
9
Forks
40
Avg merge
1d 22h
Merged PRs (30d)
19

Description

  • everything that cannot be locked by other actions (no matter whether it is something updated by this action, or just something that ought to stay the same throughout), should be locked all together, right at the beginning.
  • this should be a convention
  • Since postgres seems to automatically lock the primary key of the other side of the relation when it is written as a foreign key somewhere else, we’ll need to pay attention that it is manually locked as well

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the action locking code and reviewing how PostgreSQL locks foreign-key-related primary keys. Done means each action locks all non-delegable state at the beginning, including the related primary key where needed, following one consistent convention.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql, python
Domain
backend, databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.