OpenSlides / OpenSlides/openslides-backend

[ReAct] Lock for sub-actions in top-action

Open
#3,764 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
9
Forks
40
Avg merge
1d 22h
Merged PRs (30d)
19

Description

  • Since this would be a bit hard to coordinate between the actions, the prefetch of the top-action could be made to call the prefetch of the sub-action. Maybe by pre-calculating the data the sub-action would be called with to create custom action_data.
  • The execute_other action method could then be given a parameter telling the sub-action to not call prefetch because all prefetching for this action is guaranteed to already have happened in the top-action.
  • We might have to turn prefetch into a class method, because otherwise we will have to create a class instance by hand every time we do this. We’re already doing that during execute_other_action, we don’t need that in the prefetch as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the ReAct prefetch flow and the execute_other action method, focusing on how top-actions invoke sub-actions. Determine how prefetch data and the proposed skip signal should move through that call chain. Done means the top-action coordinates sub-action prefetching and execution does not repeat work.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.