OpenSlides / OpenSlides/openslides-backend

Revert workarounds from #3635

Open
#3,640 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clean up migration waiting
Dominant language
Python
Stars
9
Forks
40
Avg merge
1d 22h
Merged PRs (30d)
19

Description

See #3635
There were some workarounds introduced here to stop empty_fields errors.
Those errors should've not happened in the first place, they are basically the result of data that doesn't fit our definitions, however we currently cannot introduce migrations, therefore: workarounds.

Once the database migration system is done:
Revert the workarounds (i.e. mainly the changes to the fields.py file), fix any action that writes wrong data and, if necessary, write a migration to fix the broken data in the database.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #3635 and the changes in fields.py that introduced the workarounds. After the database migration system is available, identify actions that write data outside the definitions, revert the workarounds, and determine whether a migration is needed to repair existing database data.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, database
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.