OpenSlides / OpenSlides/openslides-backend

[DaMMi] reconsider diff structure for edit dict

Open
#3,639 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs discussion
Dominant language
Python
Stars
9
Forks
40
Avg merge
1d 22h
Merged PRs (30d)
19

Description

Currently there are the following Todos. They need to be discussed and respectively implemented.
TODO This has a very similar structure to the add recursive function. Maybe combine with use of lambda or passing additional dict.
TODO This should only generate diffs for the leafs. Thus the structure should be reconsidered. Maybe flatter or integrating rename info.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DaMMi edit-dict implementation and the similarly structured add recursive function. Discuss whether to combine the functions and whether diffs should contain only leaf nodes or integrate rename information; done means implementing the agreed diff structure.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.