OpenSlides / OpenSlides/openslides-backend
[RelDB] Use or delete table_alias in SqlQueryHelper.build_filter_str
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 40
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 19
Description
SqlQueryHelper.build_filter_str is called outside of this method only once, without table_alias. Check if table_alias: is always false and the code for this case is not reachable. The variable table_alias should be either used or deleted.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate SqlQueryHelper.build_filter_str and its sole caller, then inspect how table_alias is handled in the method. Confirm whether the alias branch is unreachable and resolve the variable's use or removal consistently. Run the relevant backend tests to verify filter SQL generation remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, sql
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100