OpenSlides / OpenSlides/openslides-backend
[relDB] Assortment of likely refactorings and cleanups
Open
Nobody has claimed this yet.
clean up
- Dominant language
- Python
- Stars
- 9
- Forks
- 40
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 19
Description
Mostly from various TODOs:
- database_reader.py ln.198: Three lines below the comment may be unnecessary. After the tests are all fixed, they should be deleted as a test to see if they're actually necessary. If they aren't, keep them deleted, else the code may still require some clearing up.
- query_helper.py: There are 2 todos: First is for some refactoring, the second is some commented out code that either needs to be added bach in or deleted.
- patterns.py contains a
META_DELETEDandMETA_POSITIONconstant which isn't used anywhere - There are multiple actions in which meta_position is popped, that is probably not necessary anymore
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the TODOs and referenced code in database_reader.py, query_helper.py, and patterns.py, including the actions that pop meta_position. Check the existing tests before removing or restoring code; done means each listed cleanup is resolved and the test suite still passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, database
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100