OpenSlides / OpenSlides/openslides-backend
Improve check_for_archived_meeting
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 9
- Forks
- 40
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 19
Description
Incorrect error message can be raised on attempt to perform action on a meeting that does not exist. Below is one of the examples.
How to reproduce:
Open /motion/test_create_forwarded.py and modify request in test_forward_with_attachment_true_and_forward_with_attachments_disabled: replace meeting_id in `self.request1 with an id of a meeting that does not exist.
Current error message:
Meeting /2435 cannot be changed, because it is archived.
Desired behaviour:
Message to contain the information that target meeting does not exist.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in /motion/test_create_forwarded.py, using test_forward_with_attachment_true_and_forward_with_attachments_disabled and its self.request1 meeting_id to reproduce the issue. Trace check_for_archived_meeting through this request path, then verify that a nonexistent target meeting produces a message stating it does not exist rather than saying it is archived.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100