OpenSlides / OpenSlides/openslides-backend

Refactor `validate_entry` on user json_uploads

Open
#2,445 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clean up
Dominant language
Python
Stars
9
Forks
40
Avg merge
1d 22h
Merged PRs (30d)
19

Description

In user/base_json_upload.py
The method is way too long and hard to understand.
It should hopefully be possible to make it shorter/more readable/more efficient.

Maybe consider doing the same for other json_uploads

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading validate_entry in user/base_json_upload.py and identify why its current flow is difficult to follow. Compare the implementation with other json_uploads only if their validation is relevant. Done means a shorter, more readable and more efficient validation method, with equivalent behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.