OpenSlides / OpenSlides/OpenSlides
proxy: Improve HTTPS preference values
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 644
- Forks
- 182
- Avg merge
- 3h 29m
- Merged PRs (30d)
- 7
Description
Currently, HTTPS support is enabled by setting ENABLE_LOCAL_HTTPS to any value, cf. https://github.com/OpenSlides/OpenSlides/blob/95504ce8c0c51bf29c2e03ac52ddc102f05ee972/proxy/entrypoint#L29
The management tool sets it to 1 by default, cf. https://github.com/OpenSlides/openslides-manage-service/blob/6d4376fdf517cf33dfffc738179413d9feebb687/pkg/config/default-docker-compose.yml#L81.
This setup makes changing the setting very counter-intuitive because ENABLE_LOCAL_HTTPS: 0 will not disable HTTPS support. Considering that this is a user preference, the logic should be more predictable, e.g., 1/0 or true/false.
I'm mainly opening an issue for this because any change in this repository must be coordinated with the management tool's template.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with proxy/entrypoint at line 29 and compare it with ENABLE_LOCAL_HTTPS in the management tool's default-docker-compose.yml at line 81. Confirm the accepted preference convention with the management tool, then coordinate the change across both locations. Done means the documented false-like value disables HTTPS and the true-like value enables it predictably.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker-compose, shell
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100