OpenRefine / OpenRefine/CommonsExtension
Make sure thumbnails can never block the rendering of the whole grid
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 29
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
In some circumstances the code that renders thumbnails into cells can fail and that will abort the rendering of the entire grid.
See this forum post for instance: https://forum.openrefine.org/t/openrefine-3-7-9-released/1259/9?u=antonin_d
We should make sure that any exception thrown in our cell renderer is caught appropriately and a fallback is used, so that the rest of the grid is still rendered.
This safety mechanism should also be implemented on OpenRefine's side of the extension point.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked forum report, then trace the thumbnail cell renderer and OpenRefine's side of the extension point. Check how renderer exceptions currently propagate and identify the existing fallback behavior. Done means a failing thumbnail cannot abort the grid, and the remaining cells still render.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100