OpenRailAssociation / OpenRailAssociation/osrd
ui-core: dialog component should not have margin on h1 tag in header
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 660
- Forks
- 87
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 269
Description
Margin on title in header
Check here https://github.com/OpenRailAssociation/osrd/blob/dev/front/ui/ui-core/src/styles/dialog.css#L40
We should have a margin: none; or margin-bottom: none.
Scroll
On chrome, overflow:scroll always display the scrollbars even if they are not necessary.
Should use auto instead
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in front/ui/ui-core/src/styles/dialog.css at the referenced line and inspect the dialog header h1 and scroll container rules. Update the header title spacing and scrolling behavior as described, then verify in Chrome that unnecessary scrollbars are not shown and the title has no unwanted margin.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100