OpenRailAssociation / OpenRailAssociation/osrd
ui-icons : wrong height
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 660
- Forks
- 87
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 269
Description
What happened?
Regarding this comment.
Sometimes when we import an ui icon, its height is larger than the actual icon size.
We should look for a fix on ui side so we don't have to fix this issue like the one in the linked comment or with a margin/padding like we do in other parts of the app (look for to fix icon weird height in _scenario.scss
What did you expect to happen?
- this behavior doesn't happen anymore (check if the "display: flex" fix solves the issue)
- all manual fix on osrd side are removed
How can we reproduce it (as minimally and precisely as possible)?
Remove the css fix on one of the examples and inspect the icon height
On which environments the bug occurs?
Local
On which browser the bug occurs?
Firefox
OSRD version (top right corner Account button > Informations)
.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the UI icon styling and the examples where the CSS fix was removed, then search _scenario.scss for to fix icon weird height. Reproduce the issue in Firefox and check whether display: flex fixes the icon height; done means the unwanted height no longer occurs and manual OSRD-side fixes are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100