OpenRailAssociation / OpenRailAssociation/osrd
front: import fallback from tartine should not be used on non 422 errors
Open
Nobody has claimed this yet.
area:front
area:railway-manager-interface
component:train-imports
kind:bug
kind:enhancement
module:operational-studies
severity:major
- Dominant language
- TypeScript
- Stars
- 660
- Forks
- 87
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 269
Description
What happened?
See discussion in #14506
We currently fallback to a simplified import on all errors from tartine. We probably only want to fallback when tartine does not support the imported document (as well as when the url is unset).
What did you expect to happen?
No response
How can we reproduce it (as minimally and precisely as possible)?
.
On which environments the bug occurs?
Recette (SNCF)
On which browser the bug occurs?
Firefox
OSRD version (top right corner Account button > Informations)
dev
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the discussion in issue #14506, then locate the front import path that calls Tartine and inspect how its errors are handled. Confirm the fallback is limited to unsupported-document errors or an unset URL, while other Tartine errors are surfaced instead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100