Staff hire game action broken/breaking change for plugins

Operating System

Windows 10, 64-bit

OpenRCT2 build

OpenRCT2, v0.4.19.1 (0886df6244 on develop) provided by GitHub

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

No response

Describe the issue

PR #23328 broke plugins that used the StaffHireNewAction game action by changing one of the properties without a proper backwards compatibility check. Furthermore, the API declaration file was not updated, which still reflects the old API, and the new required constume ids cannot yet be retrieved from the API to properly use the game action.

To fix this I would suggest the following fixes:

• Update openrct2.d.ts with the new API.
• Add a proper method to, for example, get available costume objects which can be used with the game action.
• Add a backwards compatibility check for plugins using a plugin API version prior to the game action breaking change or fix.

Steps to reproduce

1. Write a plugin that queries or executes the StaffNewHire action.
2. Get an error for incorrect parameters.

Attachments

No response

Start with StaffHireNewAction.cpp and distribution/openrct2.d.ts, comparing the changed action properties with the declared plugin API. Trace how plugin API versions are identified and how available costume objects could be exposed. Done means existing plugins remain compatible or receive an intentional compatibility path, while the declaration and required costume IDs match the working action.