Initial money set during scenario creation for no-money maps is still added to the high score upon scenario completion.

Operating System

Windows 10, 64 bit

OpenRCT2 build

OpenRCT2, v0.4.7-137-g7043333 (7043333 on develop) provided by GitHub

Base game

RollerCoaster Tycoon 2

Area(s) with this issue?

The bug also exists in the original game (RCT2/RCTC)

Describe the issue

All of the no-money scenarios in RCT2, despite having no cash metric as the name implies, start with money that gets added to the high score upon completing the scenario. By contrast, all of RCT1's no-money maps truly have no initial money, when viewed with the enable money cheat, so no discrepancy is made there.

The majority of RCT2's no-money maps start with 10k initial cash, with two exceptions:
Extreme Heights starts with 110k
Great Wall of China starts with 5.01m

Rather than go through and patch the initial cash out of all of these maps, I think it would be simpler to have the company value calculation not factor in money when "no money" is enabled.

Steps to reproduce

1. Open any of the scenarios in RCT2 that have no money (Great Wall of China has the most visible error).
2. Use cheats to enable money to see how much starting cash there is.
3. Reset to no-money, complete the scenario as normal.
4. Observe the high score on the scenario select screen.

Attachments

Start by reproducing the issue with the Great Wall of China scenario and compare its completion high score with money enabled and disabled. Then locate the company value calculation and the no-money scenario state; done means initial money no longer contributes to the high score for no-money scenarios.